From fb80ecb2433424313064c13a8896ff1fbf361ceb Mon Sep 17 00:00:00 2001
From: MaeJong <mewiceclair@gmail.com>
Date: Sat, 20 May 2017 03:27:19 +0200
Subject: Remove GUID stub from listplayers and namelog

The GUID stub was useless, and a privacy/security leak
---
 src/game/g_admin.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

(limited to 'src')

diff --git a/src/game/g_admin.c b/src/game/g_admin.c
index daa01dc..fe0885f 100644
--- a/src/game/g_admin.c
+++ b/src/game/g_admin.c
@@ -5605,7 +5605,6 @@ qboolean G_admin_listplayers( gentity_t *ent, int skiparg )
   char n3[ MAX_NAME_LENGTH ] = {""};
   char lname[ MAX_NAME_LENGTH ];
   char lname2[ MAX_NAME_LENGTH ];
-  char guid_stub[ 9 ];
   char muted[ 2 ], denied[ 2 ], dbuilder[ 2 ], immune[ 2 ];
   int l;
   char lname_fmt[ 5 ];
@@ -5652,10 +5651,6 @@ qboolean G_admin_listplayers( gentity_t *ent, int skiparg )
       continue;
     }
 
-    for( j = 0; j < 8; j++ )
-      guid_stub[ j ] = p->pers.guid[ j + 24 ];
-    guid_stub[ j ] = '\0';
-
     muted[ 0 ] = '\0';
     if( G_admin_permission( &g_entities[ i ], ADMF_NO_VOTE ) )
     {
@@ -5749,14 +5744,13 @@ qboolean G_admin_listplayers( gentity_t *ent, int skiparg )
       karma[ 0 ] = '\0';
 
     if ( G_admin_permission(ent, ADMF_SEESFULLLISTPLAYERS ) ) {
-      ADMBP( va( "%2i %s%s^7%s %-2i %s^7 (*%s) ^1%1s%1s%1s%1s^7 %s^7 %s%s^7%s\n",
+      ADMBP( va( "%2i %s%s^7%s %-2i %s^7 ^1%1s%1s%1s%1s^7 %s^7 %s%s^7%s\n",
                i,
                c,
                t,
                karma,
                l,
                ( *lname ) ? lname2 : "", 
-               guid_stub,
                immune,
                muted,
                dbuilder,
@@ -6998,7 +6992,6 @@ qboolean G_admin_namelog( gentity_t *ent, int skiparg )
   char search[ MAX_NAME_LENGTH ] = {""};
   char s2[ MAX_NAME_LENGTH ] = {""};
   char n2[ MAX_NAME_LENGTH ] = {""};
-  char guid_stub[ 9 ];
   qboolean found = qfalse;
   int printed = 0;
 
@@ -7028,14 +7021,12 @@ qboolean G_admin_namelog( gentity_t *ent, int skiparg )
     }
     printed++;
     for( j = 0; j < 8; j++ )
-      guid_stub[ j ] = g_admin_namelog[ i ]->guid[ j + 24 ];
-    guid_stub[ j ] = '\0';
     if( g_admin_namelog[ i ]->slot > -1 )
        ADMBP( "^3" );
-    ADMBP( va( "%-2s (*%s) %15s %s^7", 
+    ADMBP( va( "%-2s %15s %s^7", 
       (g_admin_namelog[ i ]->slot > -1 ) ?
         va( "%d", g_admin_namelog[ i ]->slot ) : "-",
-      guid_stub, g_admin_namelog[ i ]->ip,
+      g_admin_namelog[ i ]->ip,
       displaySchachtmeisterJudgement( &g_admin_namelog[ i ]->smj, g_admin_namelog[ i ] ) ) );
     for( j = 0; j < MAX_ADMIN_NAMELOG_NAMES && 
       g_admin_namelog[ i ]->name[ j ][ 0 ]; j++ )
-- 
cgit