summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-01-10Batch of bug fixes for gamecode. Patch compiled and log message written by ↵Thilo Schulz
Tobias Kuehnhammer (#5144) ################################################################################ This Patch fixes: ################################################################################ - The "fraglimit warning" was not played at all, if on the blue team. - The "where" console command was broken. - Obelisk explosion wasn't drawn if no Rocketlauncher was loaded. - Impact marks sometimes didn't draw at all. - IMPORTANT BUGFIX: No killing for cheaters with Lightning gun and Gauntlet. - If two doors are close to each other a spectator couldn't fly through them. - More robust, efficient and logical respawning routine. NOTE: The game.qvm will get notable smaller and will use LESS MEMORY! - Drowning sounds are fixed. Now they are played as intended. (as the id comment in the source code shows). - Some AI bugs (OVERFLOW!) in the bot movement code. - Several "Team Arena" Overload and Harvester bugs. - Stops bots from attacking a team mate (player) who only changed teams. - Some voice chats and CTF commands fixed. - "Team_ReturnFlag" was called twice, which did wired things sometimes. NOTE: (G_RunItem checks CONTENTS_NODROP already!) - A bugfix for Gauntlet animation. - Incorrect CTF scoring. - A bunch of corrected comments and print lines ("\n"). - Some regularity of expression and some small trivial bugs. ################################################################################ Details: ################################################################################ ******************************************************************************** BUG: in gamemode GT_TEAM the fraglimit warning will not be played if joining the blue team! -------------------------------------------------------------------------------- Solution: In "CG_CheckLocalSounds": if cgs.scores2 > highScore, highScore should be cgs.scores2. ******************************************************************************** BUG: the "where" console command doesn't work as expected (it's always 0 0 0) but not in id Quake 3 Arena. It seems that now Ioquake3 is affected! -------------------------------------------------------------------------------- Solution: In Function "Cmd_Where_f" ent->s.origin should be ent->r.currentOrigin. ******************************************************************************** BUG: in gamemode GT_OBELISK obelisk explosion won't be drawn if there is no Rocketlauncher loaded. (The "maps without Rocketlauncher" bug) -------------------------------------------------------------------------------- Solution: in "cg_main.c": cgs.media.rocketExplosionShader should be registered if gamemode is GT_OBELISK. ******************************************************************************** BUG: Impact marks sometimes doesn't draw at all. Not easy to reproduce if you don't play (io)Quake3 every day and know the places where it happens! ;) But anyway... Test: start q3dm12 go to "Long Jump Canyon" (where the small platform teleporter for the BFG is) place yourself at the point where the railgun spawns, look in the direction where the red suspended armor is. Now shoot at the sloped wall on the out/leftside of the door you see. (the sloped wall should be nearly in the center of your screen now). If you choose the correct brush face and shoot up and down at this brush face, the impact marks sometimes aren't visible. There are hundreds of custom maps where this can happen! -------------------------------------------------------------------------------- Solution: I replaced the function "SnapVectorTowards" with the one from "Wolfenstein - Enemy Territory (GPL Source Code)" ******************************************************************************** BUG: Normally "NOCLIP" cheaters are logically not allowed to fire a gun. Unfortunatly the Gauntlet (and Lightning gun) was forgotten and not restricted to that. All weapons except those two were handled correct. -------------------------------------------------------------------------------- Solution: Make Gauntlet and Lightning gun not firing for someone who cheats with "NOCLIP" (like all other weapons). ******************************************************************************** NOTE: A few bugfixes are not mine and are reported here: http://www.quake3world.com/forum/viewtopic.php?f=16&t=9179. Thanks to Quake3world, for all those years and the good guys there! ******************************************************************************** BUG: During making a mod I found a very strange bug, which mainly occurs if someone tries to implement a lot of singleplayer monsters which should walk slowly (like the "Crash" bot). So if someone wants to make slow down bots or monsters when they are walking towards a goal and alter the function "BotMoveInGoalArea" then the bots/monsters do stupid things. Otherwise and this is the default (also buggy) behavior they start running although they shouldn't (as seen with the "Crash" bot and will not be fixed here). -------------------------------------------------------------------------------- Solution: Fix overflow in bot user command. BUGFIX from "Hunt" mod by J. Hoffman. ******************************************************************************** BUG: in function "BotMoveToGoal" the special elevator case doesn't make sense. -------------------------------------------------------------------------------- Solution: in "be_ai_move.c": ((result->flags & MOVERESULT_ONTOPOF_FUNCBOB) || (result->flags & MOVERESULT_ONTOPOF_FUNCBOB)) should be ((result->flags & MOVERESULT_ONTOPOF_ELEVATOR) || (result->flags & MOVERESULT_ONTOPOF_FUNCBOB)). ******************************************************************************** BUG: in function "BotWantsToRetreat" and "BotWantsToChase" this is wrong: "(bs->enemy != redobelisk.entitynum || bs->enemy != blueobelisk.entitynum)" -------------------------------------------------------------------------------- Solution: "... redobelisk.entitynum) && (bs->enemy != blueobelisk.." is correct. ******************************************************************************** BUG: in gamemode GT_OBELISK there are too many node switches for bots (test: mpq3tourney6 with many bots). If that happens, game becomes unplayable. I don't know if this is the best solution but here it is: -------------------------------------------------------------------------------- Solution: In function "AINode_Battle_Fight" right after: if (!BotEntityVisible(bs->entitynum, bs->eye, bs->viewangles, 360, bs->enemy)) { I added this: #ifdef MISSIONPACK if (bs->enemy == redobelisk.entitynum || bs->enemy == blueobelisk.entitynum) { AIEnter_Battle_Chase(bs, "battle fight: obelisk out of sight"); return qfalse; } #endif ******************************************************************************** BUG: in gamemode >= GT_TEAM, after team change, bots will (sometimes) not stop shooting at you, although you are on their team now. It seems that the configstrings are f***** up or not reliable in this case! -------------------------------------------------------------------------------- Solution: In function "BotTeam" and "BotSameTeam" get the real team values. ******************************************************************************** BUG: Some of the bots voice commands are wrong. They are commanded to attack the enemy base but they say "Okay, I will defend!" -------------------------------------------------------------------------------- Solution: Corrected some voice commands in "BotCTFOrders_FlagNotAtBase" and "Bot1FCTFOrders_EnemyDroppedFlag" ******************************************************************************** BUG: Spectators couldn't fly through doors if they are very close to each other. You can test it with some regular id maps (q3dm14, q3dm12) but there are also many custom maps where this can happen! This is annoying because in the worst case you can't move at all and are caught inside a door. -------------------------------------------------------------------------------- Solution: There is a solution in a mod called "Hunt" by J. Hoffman. Bugfix is included in this patch! ******************************************************************************** BUG: During making a mod I found it very hard to implement some of my ideas (something like "Limbo" or "Meeting") because of the way the player spawn effect, intermission and spawning on victory pads is handled. I reworked it a bit and simplified it so that the effect is handled when a client respawns (as the name says) and not when a client begins. I think this will help more mod makers everytime they want to make changes to spawning of players, bots on victory pads or monsters... and want to avoid spectators with Machineguns which can kill and score... :() NOTE: I also renamed the poorly named function "respawn" to "ClientRespawn". If someone searches the code base for "respawn" it was really hard to find the correct place for what was meant. "respawn" is used so often, that you really get headache ... now with "ClientRespawn" it's easier! IMPORTANT: The whole respawning, moving to intermission point and everything related to that is now done in a more reliable way without changing the default behavior. (How critical the whole spwaning mess was did you see by yourself (ioquake3 rev. 2076). With this patch it's safer. Trust me, I spent hours of fixing silly problems... -------------------------------------------------------------------------------- Solution: Simplified "ClientBegin" and moved the teleport event to "ClientSpawn". ******************************************************************************** BUG: If a player is dying or hurted under water the hurt/dying sounds AND the drowning sounds are played together. This is silly. Moreover it's no good idea to let the server play client sounds! There was a solution in a mod called "Q3A++" by Dan 'Neurobasher' Gomes which fixes the problem. -------------------------------------------------------------------------------- Solution: Created a "CG_WaterLevel" function to play the appropriate sounds. ******************************************************************************** ################################################################################
2013-01-10- Fix already defined command warnings for minimize - Fix recursive ↵Thilo Schulz
CL_Shutdown warning and "command already defined" warnings when quitting while playing on a server that changed the gamedir.
2013-01-10Don't search system directories for renderer libThilo Schulz
2013-01-10Add forgotten file for last revThilo Schulz
2013-01-10Modular rendering system. Patch by use.less01 This might break MSVC builds. ↵Thilo Schulz
I'll take care of it later
2013-01-10Fix pak order when reconnecting to a server. When /connect to the same ↵Thilo Schulz
server is issued while already connected, an initial call to CL_Disconnect will remove all pak file references and reset the pak order. Reordering only occurs through FS_Restart, which in turn is called when checksum feed changes. Because we reconnect to the same server, checksum feed never changes and pak file order is not restored to server order again. With certain pak file constellations between client/server, this may result in an inability to load files from paks which are not correctly detected as referenced paks.
2013-01-10Fix strange ifdeffery (#5140)Thilo Schulz
2013-01-10Change DLL search path order for external libraries that are linked at ↵Thilo Schulz
runtime, like libcurl or libopenal to: * system library paths * executable path * fs_basepath
2013-01-10- Switch master server protocol to dpmaster for better game separation. ↵Thilo Schulz
Based partly on patch by Zack Middleton - Get rid of ugly cvars sv_heartbeat and cl_gamename and replace with single com_gamename - Remove sv_flatline. Flatlines are ignored by dpmaster and are considered to be insecure because flatlines can be udp-spoofed.
2013-01-10Bug 5094 - Code cleanup, patch by Zack Middleton and DevHC. Fixes ↵Thilo Schulz
unused-but-set gcc warnings
2013-01-10Fix menu corruption on IRIX (#5097), patch by Rainer CanavanThilo Schulz
2013-01-10- Apply parts of Ben Millwood's target bitfield patch (#3787) - Fix Ryan's ↵Thilo Schulz
FIXME and have voip packet buffer on the server dynamically allocated via Z_Malloc and store pointers in a circular buffer - Improve voip target parsing on top of Ben Millwood's patch - Add new "spatial" target where speaker is spatialized in 3d space and can be heard by all clients in hearing range (s_alMaxDistance) (#4467) - Decrease voip sound lengths from 240ms to 80ms per voip packet to mitigate udp packet loss and decrease latency - Protocol version incremented to 71
2013-01-10Bug 5096 - Define PRODUCT_VERSION in q_shared.h if it is not, patch by Zack ↵Thilo Schulz
Middleton
2013-01-10Fix extension name comparison for DLL filesThilo Schulz
2013-01-10* Replace usage of system with fork/execTim Angus
2013-01-10Fix client crash on windows with old OpenALThilo Schulz
2013-01-10Revert attribute patch from r2090 because the jpeg functions really ↵Thilo Schulz
shouldn't be deviating from the codebase unnecessarily
2013-01-10* Fix various issues with unix Sys_DialogTim Angus
2013-01-10- Bug 5083 - Cross compiling for 64bit is missing libcurl.a - Fix a compiler ↵Thilo Schulz
warning for cross compile
2013-01-10Bug 4812 - GCC __attribute__ annotations for printf, non-returning functions ↵Thilo Schulz
etc., patch by linux@youmustbejoking.demon.co.uk and Zack Middleton
2013-01-10Fix delta compression breaking due to packet queuingThilo Schulz
2013-01-10* Use specific exit code for xmessageTim Angus
2013-01-10Fix legacy protocol with new packet queueingThilo Schulz
2013-01-10Fix alignment issues in message sending/reading that would crash IRIX, ↵Thilo Schulz
thanks to Canavan for supplying a shell where I could fix this (#5077)
2013-01-10Fix compile for USE_VOIP=0Thilo Schulz
2013-01-10Bug 5075 - Fix comments in quake3 configs, patch by q3urt.undead@gmail.comThilo Schulz
2013-01-10Move rate limiting / queued packet sending logic from Com_Frame() to sv_main.cThilo Schulz
2013-01-10Have server send protocol version in challengeResponse so protocol ↵Thilo Schulz
negotiation works. (Where did this one get lost?)
2013-01-10- Revert back to Z_Malloc from Hunk_FreeTempMemory introduced in r2077 as ↵Thilo Schulz
Hunk_FreeTempMemory must be freed in LIFO order (#5079) - Introduce SV_ClientFree() to prevent memory leaks r2077 was supposed to fix
2013-01-10Remove one unnecessary loop in the beginningThilo Schulz
2013-01-10- Make sure at least one round of download packets and packet queues gets ↵Thilo Schulz
sent each frame - Fix timeVal select timeout value for case of unlimited data rate and now downloads are active
2013-01-10- Forgot to mention: last rev (2077) bumped default protocol version to 70 - ↵Thilo Schulz
Fix queued packet rate control
2013-01-10- Improve snapshot rate and data rate control - Make server send packet ↵Thilo Schulz
fragments and queued packets when server is idle - Voip protocol detection is tied to com_protocol making past-end-of-message reading unncessary - Use Hunk_AllocateTempMemory() for buffering VOIP packets and fix buffering scheme that ryan hates so much - Disable packet scrambling for new protocol as it is useless now - Get rid of the old packet scrambling functions predating latest point release - Use Hunk_AllocateTempMemory() for netchan packet queue to fix memory leak when client gets disconnected with packets in the queue - Use Hunk_AllocateTempMemory() for download blocks to fix memory leak when client gets disconnected with download blocks in the queue - Fix SV_RateMsec to account for udp/udp6 packet lengths
2013-01-10- Implement dual protocol support (#4962) - Fix several UDP spoofing ↵Thilo Schulz
security issues
2013-01-10Forgot to set default rate back to 100kbyte/sThilo Schulz
2013-01-10- Greatly improve UDP downloading speed for clients - Add download rate ↵Thilo Schulz
control cvar sv_dlRate - Don't send snapshots to downloading clients
2013-01-10Permit downloading files larger than 65 Megabytes via UDP by working around ↵Thilo Schulz
short int wraparound.
2013-01-10Bug 5069 - Remove unused variable console_color, by uZuThilo Schulz
2013-01-10Make naming a bit more foolproof for new macroThilo Schulz
2013-01-10- Add better protection against DoSing connecting users from connecting - ↵Thilo Schulz
Have Com_sprintf return string length - add STR_LEN macro for static strings
2013-01-10More color fixes for railgunThilo Schulz
Show other players' railgun color and their firetime state. Show snapshot client's color on world item models of railgun. Fix the impact mark using color2 (spiral) rather than color1 (beam). Credits go to Ensiform and Harekiet for the refire portion.
2013-01-10All patches by Zack Middleton: - Bug 5057 - Two weapon number range checks ↵Thilo Schulz
allows invalid number - Bug 5058 - Railgun explosion cannot be colorized - Bug 5059 - Client's railgun does not glow in third person and mirror - Bug 5060 - Warning in RAVENMD4 R_GetAnimTag cross compiling with amd64-mingw32
2013-01-10- Fix opStack size for vm_x86.c - Change opStack alignment to 16 for vm_x86_64.cThilo Schulz
2013-01-10Make sound fallback behaviour for music streams less verboseThilo Schulz
2013-01-10Add forced VM unloading to Com_Quit_fThilo Schulz
2013-01-10Fix ipv6 server queryThilo Schulz
2013-01-10Allow recursive VM entry for VM operations as wellThilo Schulz
2013-01-10- Automatically reset fs_game to "" if it was supplied by the user and is ↵Thilo Schulz
equal to com_basegame - Fix problem where users could change values of CVAR_INIT variables after the call to Cvar_Get() via Com_StartupVariable() - Move sound shutdown after client shutdown so VMs don't hold invalid sound handles in memory
2013-01-10- align sse control word storage space to 16 byte boundary for snapvector - ↵Thilo Schulz
replace some whitespace with tabs in snapvector.c - Give gcc a bit more freedom in choice of registers
2013-01-10- Clear ip address listings after a NET_Restart - check for oldGameSet ↵Thilo Schulz
instead of the gamename string